Switch manual validation to automatic #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
mswatosh
approved these changes
Nov 28, 2023
| JsonArrayBuilder messages = Json.createArrayBuilder(); | ||
| for (ConstraintViolation<CrewMember> v : violations) { | ||
| for (ConstraintViolation<?> v : x.getConstraintViolations()) { |
There was a problem hiding this comment.
I had tried this before, but I was missing this piece. I didn't realize we could get the violations out of the exception, so we can still return them to the UI
There was a problem hiding this comment.
Actually I think I was validating at the REST layer, instead of with jakarta data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample is manually requesting validation. It could instead annotate the parameter to
saveand get the Jakarta Data provider to automatically request it.